Support GHC-8.8.1 #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GHC-8.8.1 to the Travis build matrix and `tested-with` in the Cabal file. - Bump to a nightly LTS version using GHC-8.8.1 in preparation for a stable LTS release for GHC-8.8.1. - Use explicit imports in a few places to avoid warnings about unnecessary imports. - Update the versions of ffmpeg that the library has been tested with.
lancelet
commented
Oct 7, 2019
| @@ -9,8 +9,8 @@ import Codec.FFmpeg.Scaler | |||
| import Codec.FFmpeg.Types | |||
| import Control.Arrow (first) | |||
| import Control.Monad (when, void) | |||
| import Control.Monad.Except | |||
| import Control.Monad.Trans.Maybe | |||
| import Control.Monad.Except (MonadIO, MonadError, liftIO, throwError, catchError) | |||
There was a problem hiding this comment.
For ghc-8.8.1, without using explicit imports here, somehow when and void get imported here, leading to a warning about unnecessary imports for Control.Monad (when, void).
|
This might need a minor version bump. I'm never completely sure about how the PVP applies in situations like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested-within the Cabal file.